I see, if all regressions already existed in 1.1, then this seems g2g. Unfortunately I’m on PTO now, but I’m sure my Airbnb colleagues will be happy to verify and vote to ship this out.
Erik On Wed, Jun 30, 2021 at 6:18 PM Junlin Chen <[email protected]> wrote: > Hi Erik, These are old/cosmetic bugs, nothing blocking here, and the > majority of those will be fixed in 1.3. Let's move the release forward. > > On Wed, Jun 9, 2021 at 7:33 AM Erik Ritter <[email protected] > .invalid> > wrote: > > > Quick question about the functional regressions Junlin: > > > > Are these regressions from 1.1? If so, then since they're known shouldn't > > we ensure they aren't broken in the 1.2 release? I would expect potential > > minor, unknown regressions in a new release (maybe something visual or an > > edge case) but not a release to go out with known, functional > regressions. > > Thoughts? > > > > Erik > > > > On Tue, Jun 8, 2021 at 4:39 PM Junlin Chen <[email protected]> wrote: > > > > > +1 > > > Many known functional regression like SORT control, backend pagination > in > > > Table and visual regression - Tab and select component etc will be > > > addressed in v1.3(soon) > > > > > > The QA team @Rosemarie Chiu <[email protected]> (@rosemarie-chiu) > > > and @Jinghua > > > Yao <[email protected]> (@jinghua-qa) have put together a Superset > > release > > > sanity check test run > > > < > > > > > > https://docs.google.com/spreadsheets/d/1ghbmLdCkoaykAnoHPWpeXt-ow_PLitgTCOwtZeNSKBI/edit#gid=0 > > > > > > > for the community to participate in future Superset releases. 🙏 > > > We are also in the process of improving spinning up the ephemeral > > > environments for community rc testing. > > > Participating in QA is a great way for non-technical community members > to > > > contribute to the project, and we would love to see your feedback on > how > > we > > > can improve the release process and quality of the product(by > commenting > > in > > > the google sheet). > > > > > > thanks! > > > > > > On Mon, Jun 7, 2021 at 6:56 AM Ville Brofeldt < > > [email protected]> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > Checked as follows, > > > > > > > > - Signature and hash are correct > > > > - Version is correct in package.json > > > > - LICENSE and NOTICE file exist > > > > - NOTICE year is correct > > > > - CHANGELOG.md contains entries for release > > > > - UPDATING.md contains entries for release > > > > - Can build from source > > > > - Can run examples > > > > - Can install via pip > > > > > > > > I also tested the following: > > > > - Add a new database > > > > - Click through the majority of example dashboards > > > > - Run a query is SQL Lab > > > > - Execute Jinja in query > > > > - Explore a virtual dataset > > > > > > > > Ville > > > > > > > > > On 25. May 2021, at 12.56, Amit Miran <[email protected]> > wrote: > > > > > > > > > > Hello Superset Community, > > > > > > > > > > This is a call for the vote to release Apache Superset version > 1.2.0. > > > > > > > > > > The release candidate: > > > > > https://dist.apache.org/repos/dist/dev/superset/1.2.0rc2/ > > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/superset/tree/1.2.0rc2 > > > > > > > > > > The Change Log for the release: > > > > > https://github.com/apache/superset/blob/1.2.0rc2/CHANGELOG.md > > > > > > > > > > The Updating instructions for the release: > > > > > https://github.com/apache/superset/blob/1.2.0rc2/UPDATING.md > > > > > > > > > > public keys are available at: > > > > > > > > > > https://www.apache.org/dist/superset/KEYS > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > > number > > > > > of votes are reached. > > > > > > > > > > Please vote accordingly: > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > Thanks, > > > > > The Apache Superset Team > > > > > > > > > > > > > >
