I’m so glad to see a patch release follow up to 1.3.0. I feel though that if we truly wanted to call this a patch/fix release that it should only have bug fixes and no features. I would propose to only include the fixes and leave the feature cherries for 1.4.0.
Elizabeth > On Sep 7, 2021, at 10:26 AM, Ville Brofeldt <[email protected]> > wrote: > > Hi all, > > Sure thing, happy to kick off an rc2 with #16258. However, AFAIK it only > affects Presto, so rc1 should still be fine on other connections. So I’ll > leave the rc open for a while longer, and will bake rc2 later this week if > other important bugs/fixes surface. > > Ville > >> On 7. Sep 2021, at 17.54, Erik Ritter <[email protected]> wrote: >> >> -1, as this is missing a pretty big cherry just fixed by Ville himself! >> >> I'd recommend recutting a branch with >> https://github.com/apache/superset/pull/16614 added that resolves >> https://github.com/apache/superset/issues/16258. >> >> Best, >> Erik >> >>> On Tue, Sep 7, 2021 at 4:11 AM Yongjie <[email protected]> wrote: >>> >>> +1 (binding) >>> >>> On Mon, Sep 6, 2021 at 9:11 PM Ville Brofeldt <[email protected]> >>> wrote: >>> >>>> FYI, the image is now also available on docker hub: >>>> >>>> >>>> >>> https://hub.docker.com/layers/apache/superset/1.3.1rc1-dev/images/sha256-8f459c1568650201d99fc76d84bdfcc2a5358e0ac25e96143bf01c9d1481df49?context=explore >>>> >>>> Ville >>>> >>>> On 6. Sep 2021, at 15.33, Ville Brofeldt <[email protected]> >>>> wrote: >>>> >>>> Hello Superset Community, >>>> >>>> This is a call for the vote to release Apache Superset version 1.3.1. >>>> This release candidate includes the following cherries on top of 1.3.0: >>>> >>>> Features: >>>> - #16594 feat: Experimental cross-filter plugins (@simcha90) >>>> - #16416 feat: add Shillelagh DB engine spec (@betodealmeida) >>>> - #16167 feat: Adding Rockset db engine spec (@srinify) >>>> >>>> Fixes: >>>> - #16592 fix: Remove export CSV in old filter box (@duynguyenhoang) >>>> - #16573 fix: impersonate user label/tooltip (@betodealmeida) >>>> - #16412 fix: Support Jinja template functions in global async queries >>>> (@robdiciuccio) >>>> - #16482 fix: can't drop column when name overlap (@zhaoyongjie) >>>> - #16526 fix: Set correct comparison operator for snowflake-sqlalchemy >>>> pinning (@danielewood) >>>> - #16372 fix: ensure setting operator to `None` (#16371) (@grumpy-miner) >>>> - #16515 fix: Pin snowflake-sqlalchemy to 1.2.4 (@danielewood) >>>> - #16468 fix(native-filters): handle undefined control value gracefully >>>> (@villebro) >>>> - #16464 fix: prevent page crash when chart can't render (@zhaoyongjie) >>>> - #16460 fix(native-filters): handle null values in value filter >>>> (@villebro) >>>> - #16299 fix: copy to Clipboard order (@AAfghahi) >>>> - #16369 fix: call external metadata endpoint with correct rison object >>>> (@villebro) >>>> - #16293 fix(sqlite): week grain refer to day of week (@villebro) >>>> - #16193 refactor: external metadata fetch API (@zhaoyongjie) >>>> >>>> The release candidate: >>>> https://dist.apache.org/repos/dist/dev/superset/1.3.1rc1/ >>>> >>>> Git tag for the release: >>>> https://github.com/apache/superset/tree/1.3.1rc1 >>>> >>>> The Change Log for the release: >>>> https://github.com/apache/superset/blob/1.3.1rc1/CHANGELOG.md >>>> >>>> The Updating instructions for the release (unchanged from 1.3.0): >>>> https://github.com/apache/superset/blob/1.3.1rc1/UPDATING.md >>>> >>>> public keys are available at: >>>> >>>> https://www.apache.org/dist/superset/KEYS >>>> >>>> The vote will be open for at least 72 hours or until the necessary number >>>> of votes are reached. >>>> >>>> Please vote accordingly: >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove with the reason >>>> >>>> Thanks, >>>> The Apache Superset Team >>>> -------------------------- >>>> >>>> >>>> >>> >
