+1 (binding) with the caveat that I agree with Michael on standardizing 
components/sizes/etc in all our modals wherever possible, and (over time) 
stabilizing these “atoms” and “molecules” in our design system.

-e-

Evan Rusackas
Preset | preset.io
Apache Superset PMC
On Apr 4, 2024 at 2:29 PM -0600, Tai Dupree <tdupree...@gmail.com>, wrote:
> +1!
>
> On Thu, Apr 4, 2024 at 9:05 AM Antonio Rivero <antonioriveroc...@gmail.com>
> wrote:
>
> > +1
> >
> > Antonio.
> >
> > > On 04-04-2024, at 2:00 AM, Elizabeth Thompson
> > <elizab...@preset.io.INVALID> wrote:
> > >
> > > Hi All,
> > > I’d like to call a vote for the SIP on Alerts and Reports Modal with
> > Dashboard Filters and Tabs. In the end we were undecided about how to build
> > all the features that would solve the requirements for multiple parties and
> > decided to go with a simplified MVP behind a feature flag and build out on
> > the alerts and reports filters and tabs incrementally to add more
> > functionality in the future (potentially with additional SIPs). This SIP
> > and vote will be for the MVP version which will be behind the
> > ALERT_REPORT_TABS feature flag.
> > >
> > >
> > > The vote will be open for at least 72 hours or until the necessary number
> > > of votes are reached. Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Thanks to everyone for all the participation and input on the SIP and to
> > Lily Kuang and Jack Fisher for all their work so far on preparing the SIP
> > and for the feature development.
> > > Elizabeth
> > >
> > >
> > > https://github.com/apache/superset/issues/26183
> > >
> >
> >
>
> --
> -Tai Dupree

Reply via email to