+1 (binding) I think most deployments won't use this but with it well-thought out (thanks for the SIP discussion) and behind a config setting, it's reasonable to bundle it with Superset so it's available out of the box. It might be a selling point for using Superset in certain industries.
Sam On Sat, Nov 7, 2026, at 3:05 AM, 김승갑 wrote: > Hi all, > > I'd like to call a vote on SIP-230: an opt-in download reason for > CSV/XLSX exports. > > Discussion thread: > https://www.google.com/url?q=https://lists.apache.org/thread.html/xkfnvh32xwq4ocnml9r1p3qgpzn2v6fq&source=gmail&ust=1794125157439000&sa=E > SIP: > https://www.google.com/url?q=https://github.com/apache/superset/issues/44512&source=gmail&ust=1794125157439000&sa=E > Reference PR: > https://www.google.com/url?q=https://github.com/apache/superset/pull/44499&source=gmail&ust=1794125157439000&sa=E > > Summary: > - A new config setting, REQUIRE_DOWNLOAD_REASON (default False, set in > superset_config.py). It is a config key and not a feature flag, as > suggested in the discussion. > - When on, the UI asks for a short reason before a CSV/XLSX export > (Explore, dashboard charts, dashboard-wide Excel, SQL Lab), and the > backend rejects export requests without one. > - The reason is recorded in the existing Action Log entry. No new table. > - Scheduled reports supply their own reason automatically. > - When off, nothing changes. > > Following the feedback on the discussion thread, the check lives in one > helper on each side (superset/utils/download_reason.py and > isDownloadReasonRequired() in the frontend), so other "reason" prompts > can reuse it. The SIP text and the reference PR now describe the config > key, and CI on the PR is green. > > The vote is open for 72 hours. Please reply with: > +1 approve > 0 no opinion > -1 disapprove (please include the reason) > > Thanks, > Seunggabi (seunggabi) >
