mistercrunch commented on a change in pull request #3183: [add] Save filters to
dashboard
URL:
https://github.com/apache/incubator-superset/pull/3183#discussion_r132234242
##########
File path: superset/assets/javascripts/dashboard/Dashboard.jsx
##########
@@ -195,6 +199,13 @@ export function dashboardContainer(dashboard,
datasources, userid) {
return f;
},
addFilter(sliceId, col, vals, merge = true, refresh = true) {
+ // If slice doesn't exist, remove the related parameters in
preselect_filters.
Review comment:
this function calls `this.updateFilterParamsInUrl` 3 times. Perhaps clearer
logic would be an if statement that validates that there is a slice and column,
put all the logic within that block, and call `this.updateFilterParamsInUrl`
once at the very end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
