xrmx commented on issue #3066: Add support for column specific fillna to viz
URL: 
https://github.com/apache/incubator-superset/pull/3066#issuecomment-323279483
 
 
   Maybe i wasn't clear but right now my visualization are not working with 
superset because NULL is not coerced to '0' (string) anymore as it was on 
caravel. So that fixes a regression for me :) Said that I don't think `<None>` 
is worst than `0` for text, we can change that to `<NULL>` so that would be 
more clear for SQL aware people. The surrounding `<>` are just a trick to have 
it show before other letters after sorting. For other types the 0 is actually 
hardcoded so I am not changing any behaviour.
   
   UPDATE: maybe i can use a preceding space before NULL to be more SQL-like
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to