RoganW commented on a change in pull request #3335: [dashboard] re-enabling
cascading filters
URL:
https://github.com/apache/incubator-superset/pull/3335#discussion_r133891648
##########
File path: superset/assets/javascripts/dashboard/Dashboard.jsx
##########
@@ -190,6 +186,10 @@ export function dashboardContainer(dashboard,
datasources, userid) {
immuneToFields = this.metadata.filter_immune_slice_fields[sliceId];
}
for (const filteringSliceId in this.filters) {
+ if (filteringSliceId == sliceId) {
Review comment:
shouldn't it be `===` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
