xrmx commented on a change in pull request #3375: Improved Datatables View (and
some other minor improvements as well)
URL:
https://github.com/apache/incubator-superset/pull/3375#discussion_r135356182
##########
File path: superset/assets/visualizations/filter_box.jsx
##########
@@ -10,19 +10,25 @@ import { TIME_CHOICES } from './constants';
import './filter_box.css';
const propTypes = {
- origSelectedValues: PropTypes.object,
- instantFiltering: PropTypes.bool,
filtersChoices: PropTypes.object,
onChange: PropTypes.func,
showDateFilter: PropTypes.bool,
datasource: PropTypes.object.isRequired,
+ showLabel: PropTypes.bool,
+ showMetricNumber: PropTypes.bool,
+ origSelectedValues: PropTypes.object,
+ instantFiltering: PropTypes.bool,
+ sliceId: PropTypes.number,
Review comment:
Are we actually using sliceId for something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
