malcolmflint commented on a change in pull request #3375: Improved Datatables
View (and some other minor improvements as well)
URL:
https://github.com/apache/incubator-superset/pull/3375#discussion_r135358117
##########
File path: superset/assets/visualizations/filter_box.jsx
##########
@@ -10,19 +10,25 @@ import { TIME_CHOICES } from './constants';
import './filter_box.css';
const propTypes = {
- origSelectedValues: PropTypes.object,
- instantFiltering: PropTypes.bool,
filtersChoices: PropTypes.object,
onChange: PropTypes.func,
showDateFilter: PropTypes.bool,
datasource: PropTypes.object.isRequired,
+ showLabel: PropTypes.bool,
+ showMetricNumber: PropTypes.bool,
+ origSelectedValues: PropTypes.object,
+ instantFiltering: PropTypes.bool,
+ sliceId: PropTypes.number,
Review comment:
It appears not. That was in there when I began work on the filter_box, so I
added to prop_types for consistency...Let me know and I'll remove it from the
entire file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
