mistercrunch commented on a change in pull request #3371: [explore] Improved
time filters controls
URL:
https://github.com/apache/incubator-superset/pull/3371#discussion_r135690711
##########
File path: superset/viz.py
##########
@@ -143,18 +143,14 @@ def query_obj(self):
# potential conflicts with column that would be named `from` or `to`
since = (
extra_filters.get('__from') or
- form_data.get("since") or
- config.get("SUPERSET_DEFAULT_SINCE", "1 year ago")
+ form_data.get("since")
)
from_dttm = utils.parse_human_datetime(since)
- now = datetime.now()
Review comment:
removing this created issues where some dashboards had expression like `180
days` that would get flipped to be in the past
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
