xrmx commented on a change in pull request #3492: PandasConnector URL: https://github.com/apache/incubator-superset/pull/3492#discussion_r139914425
########## File path: contrib/connectors/pandas/models.py ########## @@ -0,0 +1,724 @@ +from collections import OrderedDict +from datetime import datetime +import logging +from past.builtins import basestring +try: + from urllib.parse import urlparse +except ImportError: + from urlparse import urlparse + +import pandas as pd +from pandas.api.types import ( + is_string_dtype, is_numeric_dtype, is_datetime64_any_dtype) + +from sqlalchemy import ( + Column, Integer, String, ForeignKey, Text +) +import sqlalchemy as sa +from sqlalchemy.orm import backref, relationship +from sqlalchemy_utils import ChoiceType, JSONType + +from flask import escape, Markup +from flask_appbuilder import Model +from flask_babel import lazy_gettext as _ + +from superset import db, utils, sm +from superset.connectors.base.models import ( + BaseDatasource, BaseColumn, BaseMetric) +from superset.models.helpers import QueryResult, set_perm +from superset.utils import QueryStatus + + +class PandasDatabase(object): + """Non-ORM object for a Pandas Source""" + database_name = '' + + cache_timeout = None + + def __init__(self, database_name, cache_timeout): + self.database_name = database_name + self.cache_timeout = cache_timeout + + def __str__(self): + return self.database_name + + +class PandasColumn(Model, BaseColumn): + """ + ORM object for Pandas columns. + + Each Pandas Datasource can have multiple columns""" + + __tablename__ = 'pandascolumns' Review comment: We may want to be consistent with sqla backend and call it 'pandas_columns' ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
