mistercrunch commented on issue #3521: Time Series Annotation Layers URL: https://github.com/apache/incubator-superset/pull/3521#issuecomment-332332133 @fabianmenges we may need to talk to sync up about annotations, we all really like the work that you've done and do want to support the stuff you added: * slice-defined formulas * slice-defined vertical lines * slice-defined data points (X/Y) annotations using http://d3-annotation.susielu.com/ * data-based annotations, using a specific slice-types with the right constraints and guarantees, reusable across slices On top of this PR, which I would describe as: * Superset-managed Annotation Layers, to be renamed "Time Annotation Layers" to clarify, these are highly re-usage across slices. All this should be composable. I'd like to break down 1-2-3 from 4 potentially, though if we can agree on the vision we could make your current PR evolve into 1-2-4 combo. That's a pretty massive feature set though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
