rhunwicks commented on a change in pull request #3492: PandasConnector URL: https://github.com/apache/incubator-superset/pull/3492#discussion_r141713559
########## File path: dev-reqs.txt ########## @@ -1,7 +1,10 @@ +beautifulsoup4==4.6.0 +lxml==3.8.0 codeclimate-test-reporter coveralls flake8 flask_cors +lxml==3.8.0 Review comment: @xrmx - you are correct - we are specifically supporting html in `FORMATS` so I need to add those dependencies to `setup.py` or whatever requirements file we ship with PandasConnector if it lives outside core. I wonder if there are any other formats we should support by default? JSON should work by default. Excel might be useful for many people and would need `xlrd`? Given the normal Superset audience do we want to support HDF5 and/or Feather? What about SAS or Stata? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
