mistercrunch closed pull request #3722: Fix box_plot NaN issue
URL: https://github.com/apache/incubator-superset/pull/3722
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/visualizations/nvd3_vis.js
b/superset/assets/visualizations/nvd3_vis.js
index 42fe9d2552..69c7c64a4c 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -296,9 +296,7 @@ function nvd3Vis(slice, payload) {
case 'box_plot':
colorKey = 'label';
chart = nv.models.boxPlotChart();
- chart.x(function (d) {
- return d.label;
- });
+ chart.x(d => d.label);
chart.staggerLabels(true);
chart.maxBoxWidth(75); // prevent boxes from being incredibly wide
break;
@@ -353,7 +351,8 @@ function nvd3Vis(slice, payload) {
chart.x2Axis.tickFormat(xAxisFormatter);
height += 30;
}
- if (vizType !== 'dist_bar' && chart.xAxis && chart.xAxis.tickFormat) {
+ const isXAxisString = ['dist_bar', 'box_plot'].includes(vizType) >= 0;
+ if (!isXAxisString && chart.xAxis && chart.xAxis.tickFormat) {
chart.xAxis.tickFormat(xAxisFormatter);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
