michellethomas opened a new pull request #3733: Using indexOf instead of includes for isXAxisString URL: https://github.com/apache/incubator-superset/pull/3733 This [PR](https://github.com/apache/incubator-superset/pull/3722) added a check for `isXAxisString = ['dist_bar', 'box_plot'].includes(vizType) >= 0` but for a different viz type (like line) includes will evaluate to false and `false >= 0` will evaluate to true (so the formatter was not getting set). Changing to use indexOf.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
