williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r147906266
##########
File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx
##########
@@ -43,7 +45,7 @@ class SliceAdder extends React.Component {
}
onEnterModal() {
- const uri = '/sliceaddview/api/read?_flt_0_created_by=' +
this.props.dashboard.curUserId;
+ const uri = '/sliceaddview/api/read?_flt_0_created_by=' +
this.props.userId;
Review comment:
why not use string template literals? I think they're generally preferred
over concatenation. should have a lint rule for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
