williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r149287974
##########
File path:
superset/assets/javascripts/dashboard/components/DashboardContainer.jsx
##########
@@ -0,0 +1,29 @@
+import { bindActionCreators } from 'redux';
+import { connect } from 'react-redux';
+
+import * as dashboardActions from '../actions';
+import * as chartActions from '../../chart/chartAction';
+import Dashboard from './Dashboard';
+
+function mapStateToProps({ charts, dashboard }) {
+ return {
+ initMessages: dashboard.common.flash_messages,
+ timeout: dashboard.common.conf.SUPERSET_WEBSERVER_TIMEOUT,
+ dashboard: dashboard.dashboard,
+ slices: charts,
+ datasources: dashboard.datasources,
+ filters: dashboard.filters,
+ refresh: dashboard.refresh,
+ userId: dashboard.userId,
+ isStarred: !!dashboard.isStarred,
+ };
+}
+
+function mapDispatchToProps(dispatch) {
+ const actions = { ...chartActions, ...dashboardActions };
+ return {
+ actions: bindActionCreators(actions, dispatch),
+ };
+}
+
+export default connect(mapStateToProps, mapDispatchToProps)(Dashboard);
Review comment:
at this point this is probably out of the scope of this PR, but we should
also try to embrace the redux `container vs component` paradigm [described
here](https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
