graceguo-supercat closed pull request #3825: Fix misleading SQL Lab timeout
error message
URL: https://github.com/apache/incubator-superset/pull/3825
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/views/core.py b/superset/views/core.py
index 003115074c..73daeac6ad 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2138,14 +2138,12 @@ def sql_json(self):
# Sync request.
try:
- SQLLAB_TIMEOUT = config.get("SQLLAB_TIMEOUT")
- with utils.timeout(
- seconds=SQLLAB_TIMEOUT,
- error_message=(
- "The query exceeded the {SQLLAB_TIMEOUT} seconds "
- "timeout. You may want to run your query as a "
- "`CREATE TABLE AS` to prevent timeouts."
- ).format(**locals())):
+ timeout = config.get("SQLLAB_TIMEOUT")
+ timeout_msg = (
+ "The query exceeded the {timeout} seconds "
+ "timeout.").format(**locals())
+ with utils.timeout(seconds=timeout,
+ error_message=timeout_msg):
# pylint: disable=no-value-for-parameter
data = sql_lab.get_sql_results(
query_id=query_id, return_results=True)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
