mistercrunch commented on issue #3809: [cache] Fixing cache key w/ merged extra 
filters
URL: 
https://github.com/apache/incubator-superset/pull/3809#issuecomment-343373623
 
 
   Good catch. I was trying to understand whether we could just run the merge 
function once only early on in the stack (early in the view perhaps). I'm ok 
merging this as-is as well. 
   
   Whatever we do we should make sure that this feature will work as expected 
and show the `altered` tag shows when loading a slice from a filtered dash (I 
think it would work either way):
   https://github.com/apache/incubator-superset/pull/3668
   
   I found a low-pri bug around that same funcitonality/method today:
   https://github.com/apache/incubator-superset/issues/3824

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to