mistercrunch commented on a change in pull request #3906: fix the
schema-fetching problem for impala in sql_lab
URL:
https://github.com/apache/incubator-superset/pull/3906#discussion_r152045305
##########
File path: superset/db_engine_specs.py
##########
@@ -148,6 +148,10 @@ def adjust_database_uri(cls, uri, selected_schema):
def patch(cls):
pass
+ @classmethod
+ def get_schema_names(cls, inspector):
+ return sorted(inspector.get_schema_names())
Review comment:
The code calling the function is already sorting, no need to sort here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
