graceguo-supercat commented on a change in pull request #3912: When checking if you should renderTriggered make sure controls[key] exists URL: https://github.com/apache/incubator-superset/pull/3912#discussion_r152185609
########## File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx ########## @@ -53,6 +53,7 @@ class ExploreViewContainer extends React.Component { } // if any control value changed and it's an instant control if (Object.keys(np.controls).some(key => (np.controls[key].renderTrigger && + typeof this.props.controls[key] !== 'undefined' && Review comment: undefined is primitive value, so we can use `this.props.controls[key] !== undefined &&` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services