williaster commented on a change in pull request #3518: Full Annotation
Framework
URL:
https://github.com/apache/incubator-superset/pull/3518#discussion_r155893476
##########
File path: superset/assets/javascripts/modules/AnnotationTypes.js
##########
@@ -0,0 +1,29 @@
+import { VIZ_TYPES } from '../../visualizations/main';
+
+const ANNOTATION_TYPES = {
+ FORMULA: 'FORMULA',
+ EVENT: 'EVENT',
+ INTERVAL: 'INTERVAL',
+ TIME_SERIES: 'TIME_SERIES',
+ NATIVE: 'NATIVE',
Review comment:
I think we should get rid of `NATIVE` here, and as discussed offline move to
a model where you only have formulas, events, intervals, and time series. the
distinction between what is currently called "native" and "interval" should be
at the `source` level, not confounded with the `type`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
