fabianmenges commented on issue #4043: Incorrectly documented SQLALCHEMY_CUSTOM_PASSWORD_STORE URL: https://github.com/apache/incubator-superset/issues/4043#issuecomment-351737656 Hm, interesting, we are using this slightly different, which is why I didn't run into it... e.g.: ``` class ExamplePasswordStore(object): ... def get_password(self, sqla_connection): key = self._gen_key(sqla_connection.__dict__) return self.password_lookup.get(key) p_store = ExamplePasswordStore(...) SQLALCHEMY_CUSTOM_PASSWORD_STORE = p_store.get_password ``` Not sure how this wasn't caught in the unit test. https://github.com/apache/incubator-superset/blob/c84211ec449a6fc0e80f1e1b6df54cb4340ca3f7/tests/core_tests.py#L311 Anyways, two options. Either change the documentation or move the 'function' `custom_password_store` out of the Database class. @ottomata are you using the `self` reference to the `Database` object inside the password store? Otherwise I might just move the function out. @mistercrunch, any preference?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
