fabianmenges commented on issue #3518: Full Annotation Framework URL: https://github.com/apache/incubator-superset/pull/3518#issuecomment-352199265 Awesome. Looking forward to getting this in. 1. I'm having trouble reproducing the 'range filter' bug. When I apply additional filters on the time axis (x-axis) in the 'Filter' section, it changes the location of an 'Event' and 'Interval' annotation correctly. It also applies the range correctly when I change the dates in the Time sections. Do you mind sending me a screenshot or something else that shows me how to reproduce this? 2. You probably selected an 'Event' annotation which will only use the `start_dttm` of the `annotation` in the `annotation` table. If you want to see the 'rectangle' you will need to select 'Interval' annotation. 3. I think those should be different annotation types. `mathjs` allows people that can not code and only know math to configure these annotations, which is part of our use case. We want to empower PMs to build their own dashboards. That said, I like the idea of having a more powerful JS eval in addition to this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
