fabianmenges commented on a change in pull request #3518: Full Annotation
Framework
URL:
https://github.com/apache/incubator-superset/pull/3518#discussion_r157349719
##########
File path: superset/assets/javascripts/explore/exploreUtils.js
##########
@@ -1,13 +1,30 @@
/* eslint camelcase: 0 */
import URI from 'urijs';
+export function getChartKey(explore) {
+ const slice = explore.slice;
+ return slice ? ('slice_' + slice.slice_id) : 'slice';
+}
+
+export function getAnnotationJsonUrl(slice_id, form_data, isNative) {
Review comment:
I would love to get this in before that refactor. I just went through 2 days
of resolving merge conflicts because the JavaScript got refactored. And I had
this out for 4 month.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
