mistercrunch closed pull request #4079: WIP
URL: https://github.com/apache/incubator-superset/pull/4079
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/utils_tests.py b/tests/utils_tests.py
index 46d476632b..8cd20ab7aa 100644
--- a/tests/utils_tests.py
+++ b/tests/utils_tests.py
@@ -119,6 +119,15 @@ def test_merge_extra_filters_ignores_empty_filters(self):
merge_extra_filters(form_data)
self.assertEquals(form_data, expected)
+ def test_merge_extra_filters_ignores_nones(self):
+ form_data = {'extra_filters': [
+ {'col': None, 'op': 'in', 'val': ''},
+ {'col': 'B', 'op': '==', 'val': []},
+ ]}
+ expected = {'filters': []}
+ merge_extra_filters(form_data)
+ self.assertEquals(form_data, expected)
+
def test_merge_extra_filters_ignores_equal_filters(self):
form_data = {
'extra_filters': [
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
