graceguo-supercat closed pull request #4082: [bugfix] iframe and markup are
broken
URL: https://github.com/apache/incubator-superset/pull/4082
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index 9b913e4dbe..85bc854cf9 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -262,7 +262,7 @@ def get_payload(self, force=False):
df = self.get_df()
if not self.error_message:
data = self.get_data(df)
- rowcount = len(df.index)
+ rowcount = len(df.index) if df is not None else 0
except Exception as e:
logging.exception(e)
if not self.error_message:
@@ -523,7 +523,7 @@ class MarkupViz(BaseViz):
is_timeseries = False
def get_df(self):
- return True
+ return None
def get_data(self, df):
markup_type = self.form_data.get('markup_type')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
