mistercrunch commented on a change in pull request #4068: [geo] Add Deckgl
GeoJson layer
URL:
https://github.com/apache/incubator-superset/pull/4068#discussion_r157835904
##########
File path: superset/assets/visualizations/main.js
##########
@@ -42,49 +42,51 @@ export const VIZ_TYPES = {
deck_screengrid: 'deck_screengrid',
deck_grid: 'deck_grid',
deck_hex: 'deck_hex',
+ deck_geojson: 'deck_geojson',
};
const vizMap = {
- [VIZ_TYPES.area]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bar]: require('./nvd3_vis.js'),
- [VIZ_TYPES.big_number]: require('./big_number.js'),
- [VIZ_TYPES.big_number_total]: require('./big_number.js'),
- [VIZ_TYPES.box_plot]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bubble]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bullet]: require('./nvd3_vis.js'),
- [VIZ_TYPES.cal_heatmap]: require('./cal_heatmap.js'),
- [VIZ_TYPES.compare]: require('./nvd3_vis.js'),
- [VIZ_TYPES.directed_force]: require('./directed_force.js'),
- [VIZ_TYPES.chord]: require('./chord.jsx'),
- [VIZ_TYPES.dist_bar]: require('./nvd3_vis.js'),
- [VIZ_TYPES.filter_box]: require('./filter_box.jsx'),
- [VIZ_TYPES.heatmap]: require('./heatmap.js'),
- [VIZ_TYPES.histogram]: require('./histogram.js'),
- [VIZ_TYPES.horizon]: require('./horizon.js'),
- [VIZ_TYPES.iframe]: require('./iframe.js'),
- [VIZ_TYPES.line]: require('./nvd3_vis.js'),
- [VIZ_TYPES.time_pivot]: require('./nvd3_vis.js'),
- [VIZ_TYPES.mapbox]: require('./mapbox.jsx'),
- [VIZ_TYPES.markup]: require('./markup.js'),
- [VIZ_TYPES.para]: require('./parallel_coordinates.js'),
- [VIZ_TYPES.pie]: require('./nvd3_vis.js'),
- [VIZ_TYPES.pivot_table]: require('./pivot_table.js'),
- [VIZ_TYPES.sankey]: require('./sankey.js'),
- [VIZ_TYPES.separator]: require('./markup.js'),
- [VIZ_TYPES.sunburst]: require('./sunburst.js'),
- [VIZ_TYPES.table]: require('./table.js'),
- [VIZ_TYPES.time_table]: require('./time_table.jsx'),
- [VIZ_TYPES.treemap]: require('./treemap.js'),
- [VIZ_TYPES.country_map]: require('./country_map.js'),
- [VIZ_TYPES.word_cloud]: require('./word_cloud.js'),
- [VIZ_TYPES.world_map]: require('./world_map.js'),
- [VIZ_TYPES.dual_line]: require('./nvd3_vis.js'),
- [VIZ_TYPES.event_flow]: require('./EventFlow.jsx'),
- [VIZ_TYPES.paired_ttest]: require('./paired_ttest.jsx'),
- [VIZ_TYPES.partition]: require('./partition.js'),
- [VIZ_TYPES.deck_scatter]: require('./deckgl/scatter.jsx'),
- [VIZ_TYPES.deck_screengrid]: require('./deckgl/screengrid.jsx'),
- [VIZ_TYPES.deck_grid]: require('./deckgl/grid.jsx'),
- [VIZ_TYPES.deck_hex]: require('./deckgl/hex.jsx'),
+ area: require('./nvd3_vis.js'),
Review comment:
Let's use `VIZ_TYPES` here, I think you picked the wrong side of the merge
conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
