mistercrunch commented on issue #4076: Introduce Javascript controls URL: https://github.com/apache/incubator-superset/pull/4076#issuecomment-352868223 @fabianmenges thanks for the feedback. I agree that we should be extremely careful in what is exposed here, whatever goes in and out has to be treated like a public API, so no backwards incompatible changes should be allowed without release notes (if ever). We do control exactly what is accessible in the sandbox. I pass the `console` object in the context by default so users can `console.log` all they want. For instance I also pass `underscore` and `d3` in there since there's a lot of utilities users may want, though that means that if we ever want to go `d3.v4` we would have to be careful in that regard somehow as we could break user reports. After thinking this through I'm removing `d3` from the context and keeping `underscore`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
