marcusianlevine opened a new pull request #4108: Bugfix: Check datatype of 
results before converting to DataFrame
URL: https://github.com/apache/incubator-superset/pull/4108
 
 
   The [merged hotfix](https://github.com/apache/incubator-superset/pull/2412) 
#2412 resolved an [issue with Presto/Hive 
columns](https://github.com/apache/incubator-superset/issues/2398) #2398 which 
are lists of dictionaries.
   
   However, this introduced issue #3934 with traditional RDB datasources like 
MS SQL Server, which only return lists of lists. Wrapping such results in an 
outer list causes pandas to interpret the list as a single column.
   
   This PR attempts to resolve that issue by introspecting the datatype of the 
first element in the return data. The type check may not be checking for 
exactly the right thing (first row vs. any of the columns in the first row?) 
but we likely need some sort of conditional to avoid wrapping a list of lists 
in an outer list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to