marcusianlevine commented on a change in pull request #4108: [BUGFIX]: Check
datatype of results before converting to DataFrame
URL:
https://github.com/apache/incubator-superset/pull/4108#discussion_r158583747
##########
File path: superset/sql_lab.py
##########
@@ -231,11 +231,12 @@ def handle_error(msg):
# check whether the result set is comprised of lists or dict
if data and len(data) > 0:
Review comment:
Yep you're right the len check is redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
