bolkedebruin commented on issue #3604: Mapbox Visualizatuion error cause by "is 
not JSON serializable"
URL: 
https://github.com/apache/incubator-superset/issues/3604#issuecomment-353866674
 
 
   Ok I found the issue. The dimensions of the LimitSpec part of the query are 
populated with metrics or self.metrics. This is a druidmetric instead of a 
column name. 
   
   I think the logic (run_query) is wrong here and it should use dimensions 
instead and not metrics. I?m not entirely sure and need some help from @Fokko 
or @mistercrunch. Then the PR is quite simple. 
   
   Offending lines:
   
   1. 
https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L1139
   2. 
https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L1188

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to