fabianmenges commented on issue #4130: [Bugfix] Remedy for Dual Axis chart 
render bug
URL: 
https://github.com/apache/incubator-superset/pull/4130#issuecomment-354289807
 
 
   Right now, annotations are not supported with the Dual Axis Line Chart 
slices (in the sense that I have not tested and developed with them in mind and 
I'm pretty sure they are not available through the UI).
   
   @Mogball Your fix looks good, but there are probably some other things that 
need to be hooked up, for it to actually work e.g.: 
https://github.com/apache/incubator-superset/blob/master/superset/assets/javascripts/modules/AnnotationTypes.js#L59
   
   @kkalyan did you setup annotations in a time series 'single'-line chart and 
then switch over to dual line chart? We probably need to add some code that 
wipes/ignores annotations if the current slice/chart type does not support the 
type of annotation configured.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to