rreddy-gobalto closed pull request #4136: Add Select data explorer logo
URL: https://github.com/apache/incubator-superset/pull/4136
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/images/Select_logo_130x65.png
b/superset/assets/images/Select_logo_130x65.png
new file mode 100644
index 0000000000..be30130826
Binary files /dev/null and b/superset/assets/images/Select_logo_130x65.png
differ
diff --git a/superset/assets/images/favicon.ico
b/superset/assets/images/favicon.ico
new file mode 100644
index 0000000000..4b2c317b13
Binary files /dev/null and b/superset/assets/images/favicon.ico differ
diff --git a/superset/assets/stylesheets/superset.less
b/superset/assets/stylesheets/superset.less
index ae0be2cd64..30aad68365 100644
--- a/superset/assets/stylesheets/superset.less
+++ b/superset/assets/stylesheets/superset.less
@@ -128,7 +128,11 @@ span.title-block {
}
div.navbar {
z-index: 999;
+ .navbar-brand {
+ margin-top: -10px;
+ }
}
+
.datasource form div.form-control {
margin-bottom: 5px !important;
}
diff --git a/superset/config.py b/superset/config.py
index e169f12ccc..85a68438e9 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -94,10 +94,10 @@
# GLOBALS FOR APP Builder
# ------------------------------
# Uncomment to setup Your App name
-APP_NAME = 'Superset'
+APP_NAME = 'Select Data Explorer'
# Uncomment to setup an App icon
-APP_ICON = '/static/assets/images/[email protected]'
+APP_ICON = '/static/assets/images/Select_logo_130x65.png'
# Druid query timezone
# tz.tzutc() : Using utc timezone
diff --git a/superset/templates/appbuilder/navbar.html
b/superset/templates/appbuilder/navbar.html
index 0ea2daec5f..7774a3c5ef 100644
--- a/superset/templates/appbuilder/navbar.html
+++ b/superset/templates/appbuilder/navbar.html
@@ -12,7 +12,7 @@
</button>
<a class="navbar-brand" href="/superset/profile/{{ current_user.username
}}/">
<img
- width="126" src="{{ appbuilder.app_icon }}"
+ width="80px" src="{{ appbuilder.app_icon }}"
alt="{{ appbuilder.app_name }}"
/>
</a>
diff --git a/superset/templates/superset/base.html
b/superset/templates/superset/base.html
index b47104957a..f301abfdb8 100644
--- a/superset/templates/superset/base.html
+++ b/superset/templates/superset/base.html
@@ -2,7 +2,7 @@
{% block head_css %}
{{super()}}
- <link rel="icon" type="image/png" href="/static/assets/images/favicon.png">
+ <link rel="icon" type="image/png" href="/static/assets/images/favicon.ico">
<link rel="stylesheet" type="text/css" href="{{ js_manifest('theme.css')
}}" />
{% endblock %}
diff --git a/superset/templates/superset/basic.html
b/superset/templates/superset/basic.html
index ea7f5b12de..680dc0cba9 100644
--- a/superset/templates/superset/basic.html
+++ b/superset/templates/superset/basic.html
@@ -12,7 +12,7 @@
</title>
{% block head_meta %}{% endblock %}
{% block head_css %}
- <link rel="icon" type="image/png"
href="/static/assets/images/favicon.png">
+ <link rel="icon" type="image/png"
href="/static/assets/images/favicon.ico">
<link rel="stylesheet" type="text/css"
href="/static/appbuilder/css/flags/flags16.css" />
<link rel="stylesheet" type="text/css" href="{{ js_manifest('theme.css')
}}" />
<link rel="stylesheet" type="text/css"
href="/static/appbuilder/css/font-awesome.min.css">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
