fabianmenges commented on a change in pull request #4016: [cache] Using the
query as the basis of the cache key
URL:
https://github.com/apache/incubator-superset/pull/4016#discussion_r159647671
##########
File path: superset/viz.py
##########
@@ -225,44 +224,46 @@ def get_json(self, force=False):
self.get_payload(force),
default=utils.json_int_dttm_ser, ignore_nan=True)
- @property
- def cache_key(self):
- form_data = self.form_data.copy()
- merge_extra_filters(form_data)
- s = str([(k, form_data[k]) for k in sorted(form_data.keys())])
+ def cache_key(self, query_obj):
Review comment:
We probably need to include the datasource itself => you can have 2
databases with the same tables, which as far as I can tell would cause
collisions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
