hughhhh commented on a change in pull request #4173: Using user-defined
Javascript to customize geospatial visualization
URL:
https://github.com/apache/incubator-superset/pull/4173#discussion_r161032588
##########
File path: superset/assets/visualizations/deckgl/layers/geojson.jsx
##########
@@ -23,11 +25,11 @@ const convertGeoJsonColorProps = (p, colors) => {
};
};
-export default function geoJsonLayer(formData, payload) {
+export default function geoJsonLayer(formData, payload, slice) {
const fd = formData;
const fc = fd.fill_color_picker;
const sc = fd.stroke_color_picker;
- const data = payload.data.geojson.features.map(d => ({
+ let data = payload.data.geojson.features.map(d => ({
...d,
Review comment:
Why let instead of const?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
