jeffreythewang commented on a change in pull request #4185: Add new 
visualization for custom X-Y axes
URL: 
https://github.com/apache/incubator-superset/pull/4185#discussion_r162757635
 
 

 ##########
 File path: superset/assets/javascripts/explore/stores/visTypes.js
 ##########
 @@ -154,6 +154,77 @@ export const visTypes = {
     ],
   },
 
+  line_xy: {
+    label: t('XY - Line Chart'),
+    controlPanelSections: [
+      {
+        label: t('Axis Options'),
+        description: t('Select which columns or metrics to plot'),
+        expanded: true,
+        controlSetRows: [
+          ['columns_and_metrics_x'],
+          ['columns_and_metrics_y'],
+          ['slice_by'],
+        ],
+      },
+      {
+        label: t('GROUP BY'),
+        description: t('Use this section if you want a query that aggregates'),
+        controlSetRows: [
+          ['groupby'],
+          ['metrics'],
+          ['limit', 'timeseries_limit_metric'],
+          ['order_desc', null],
+        ],
+      },
+      {
+        label: t('NOT GROUPED BY'),
 
 Review comment:
   Just to note - I included `NOT GROUPED BY` to address the feature @rumbin 
mentioned above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to