mistercrunch opened a new pull request #4260: Use the query_obj as the basis 
for the cache key
URL: https://github.com/apache/incubator-superset/pull/4260
 
 
   When we recently moved from hashing form_data to define the cache_key
   towards using the rendered query instead,
   it made is such that non deterministic (time-relative) form
   control values like relative times specified in "from" and "until" time
   bound resulted in making those miss cache 100% of the time.
   
   Here we move away from using the rendered query and using the query_obj
   instead. For this to work, we need to remove `['from_dttm', 'to_dttm']` and 
add some keys (`['since', 'until', 'datasource']`) from `form_data`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to