john-bodley commented on a change in pull request #4243: Use json for imports
and exports, not pickle
URL:
https://github.com/apache/incubator-superset/pull/4243#discussion_r163152533
##########
File path: superset/utils.py
##########
@@ -240,6 +241,55 @@ def dttm_from_timtuple(d):
d.tm_year, d.tm_mon, d.tm_mday, d.tm_hour, d.tm_min, d.tm_sec)
+def decode_dashboards(o):
Review comment:
Do you think using [jsonpickle](https://jsonpickle.github.io/) with custom
[handlers](https://jsonpickle.github.io/api.html#jsonpickle-handlers-custom-serialization-handlers)
for encoding/decoding would be more pythonic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
