xrmx commented on issue #4329: Druid v0.6 compatibility (second try)
URL: 
https://github.com/apache/incubator-superset/pull/4329#issuecomment-362564316
 
 
   Just a couple of thoughts:
   - any chance that pydruid sqlalchemy dialect already handles that?
   - passing the version as parameter on an object does not look that nice, 
either storing the version as an attribute in the object or creating a subclass 
for older apis may look better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to