mistercrunch commented on a change in pull request #4329: Druid v0.6 
compatibility (second try)
URL: 
https://github.com/apache/incubator-superset/pull/4329#discussion_r165730864
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -207,13 +211,14 @@ def refresh(self, datasource_names, merge_flag, 
refreshAll):
                     if datatype == 'hyperUnique' or datatype == 'thetaSketch':
                         col_obj.count_distinct = True
                     # Allow sum/min/max for long or double
-                    if datatype == 'LONG' or datatype == 'DOUBLE':
+                    if datatype == 'LONG' or datatype == 'DOUBLE' or datatype 
== 'FLOAT':
 
 Review comment:
   let's use `datetype in ('foo', 'bar')`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to