davelpz commented on issue #4335: Not quoting column name when doing a time 
series
URL: 
https://github.com/apache/incubator-superset/issues/4335#issuecomment-362708686
 
 
   Upon further debugging I think this is the correct fix (below)
   I changed `if not self.expression and not time_grain:` to
   `if not self.expression and (not time_grain or time_grain == u'Time Column') 
:`
   
   
     ```python
       def get_timestamp_expression(self, time_grain):
           """Getting the time component of the query"""
           expr = self.expression or self.column_name
           if not self.expression and (not time_grain or time_grain == u'Time 
Column') :
               return column(expr, type_=DateTime).label(DTTM_ALIAS)
           if time_grain:
               pdf = self.python_date_format
               if pdf in ('epoch_s', 'epoch_ms'):
                   # if epoch, translate to DATE using db specific conf
                   db_spec = self.table.database.db_engine_spec
                   if pdf == 'epoch_s':
                       expr = db_spec.epoch_to_dttm().format(col=expr)
                   elif pdf == 'epoch_ms':
                       expr = db_spec.epoch_ms_to_dttm().format(col=expr)
               grain = self.table.database.grains_dict().get(time_grain, 
'{col}')
               expr = grain.function.format(col=expr)
           return literal_column(expr, type_=DateTime).label(DTTM_ALIAS)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to