betodealmeida opened a new pull request #4336: Play scrubber
   @mistercrunch, this is the play slider/scrobbler for scatterplot. I 
started creating an NPM package for the `<PlaySlider>` component, but the 
layout and style is coupled with Superset, so I thought it would be better to 
have it here.
   One thing I'm worried about these changes is that in order to get the 
start/end values for the slider the code is scanning the payload to get the 
min/max timestamps from the data. This has some advantages:
   - If you select a wide range of data (the `long_lat` sample table has a 
query since 2004, IIRC) the play slider will cover only the available data, 
making it better for exploring the results.
   - We don't need to parse the freetext ("now", "7 days ago") in Javascript.
   The only downside is that it could be slow. Let me know what you think.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to