betodealmeida commented on a change in pull request #4336: Play scrubber
URL:
https://github.com/apache/incubator-superset/pull/4336#discussion_r167369652
##########
File path: superset/assets/package.json
##########
@@ -69,6 +70,7 @@
"mapbox-gl": "^0.43.0",
"mathjs": "^3.16.3",
"moment": "2.18.1",
+ "mousetrap": "^1.6.1",
Review comment:
Yeah, it's worth doing a PR introducing some basic shortcuts.
At some point I was playing with more shortcuts (left and right to step the
scrubber, up and down to increase/decrease its width), but I was worried it
could conflict with other things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
