hughhhh commented on a change in pull request #4389: [geo] introduce "Auto 
Zoom" control
URL: 
https://github.com/apache/incubator-superset/pull/4389#discussion_r167379732
 
 

 ##########
 File path: superset/assets/visualizations/deckgl/layers/arc.jsx
 ##########
 @@ -8,6 +8,15 @@ import DeckGLContainer from './../DeckGLContainer';
 import * as common from './common';
 import sandboxedEval from '../../../javascripts/modules/sandbox';
 
+function getPoints(data) {
 
 Review comment:
   Definitely think we should work this `getPoints()` into a deckGL utils file. 
I see being used in each layer. I definitely think we should try and 
consolidate this method to work for all layers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to