mistercrunch closed pull request #4404: Fix ImportError when using BigQuery in
SQL Editor
URL: https://github.com/apache/incubator-superset/pull/4404
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index b961c03152..f0e7c67620 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -1200,8 +1200,7 @@ def convert_dttm(cls, target_type, dttm):
@classmethod
def fetch_data(cls, cursor, limit):
data = super(BQEngineSpec, cls).fetch_data(cursor, limit)
- from google.cloud.bigquery._helpers import Row # pylint:
disable=import-error
- if len(data) != 0 and isinstance(data[0], Row):
+ if len(data) != 0 and type(data[0]).__name__ == 'Row':
data = [r.values() for r in data]
return data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
