mistercrunch commented on a change in pull request #4469: Make access request
redirect to dashboard if user already has access
URL:
https://github.com/apache/incubator-superset/pull/4469#discussion_r170472378
##########
File path: superset/views/core.py
##########
@@ -842,6 +842,16 @@ def request_access(self):
.one()
)
datasources.add(datasource)
+
+ has_access = all(
+ (
+ datasource and self.datasource_access(datasource)
+ for datasource in datasources
+ ),
Review comment:
Watch out here, I'm pretty sure this dangling comma changes the structure
from passing a tuple to `all` to, instead, passing it a tuple of one element
that contains a tuple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
