john-bodley commented on issue #4500: [bugfix] Fixing regression introduced in 
#4396
URL: 
https://github.com/apache/incubator-superset/pull/4500#issuecomment-370874347
 
 
   Sorry @mistercrunch. I think I may have a fix and will add an additional 
unit test for the `markup` test. I think the solution should be:
   ```
   class MarkupViz(BaseViz):
       def get_df(self, query_obj=None):
          return None  # like before
   ```
   and 
   ```
   def get_payload(self, query_obj=None):
       ...
       if df is not None and df.empty:  # previously if df is None or df.empty
           payload['error'] = 'No data'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to