john-bodley closed pull request #3881: [linting] Cleaning up linting 
documentation
URL: https://github.com/apache/incubator-superset/pull/3881
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3051d94fdc..b4cb0e21b9 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -287,10 +287,10 @@ We use [Mocha](https://mochajs.org/), 
[Chai](http://chaijs.com/) and [Enzyme](ht
 Lint the project with:
 
     # for python
-    flake8
+    tox -e flake8
 
     # for javascript
-    npm run lint
+    tox -e eslint
 
 ## Linting with codeclimate
 Codeclimate is a service we use to measure code quality and test coverage. To 
get codeclimate's report on your branch, ideally before sending your PR, you 
can setup codeclimate against your Superset fork. After you push to your fork, 
you should be able to get the report at http://codeclimate.com . Alternatively, 
if you prefer to work locally, you can install the codeclimate cli tool.
diff --git a/tox.ini b/tox.ini
index 78198ea190..db32142ab8 100644
--- a/tox.ini
+++ b/tox.ini
@@ -46,6 +46,11 @@ commands =
   pip install -r dev-reqs.txt
   {toxinidir}/run_tests.sh
 
+[testenv:eslint]
+changedir = {toxinidir}/superset/assets
+commands =
+    npm run lint
+
 [testenv:flake8]
 commands =
     flake8


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to