ktravis opened a new pull request #4562: [bug] Fix CSV upload feature for DB 
with password
URL: https://github.com/apache/incubator-superset/pull/4562
 
 
   As of #4298, the call to `create_engine` within `create_table_from_csv` 
located 
[here](https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L138)
 is using `sqlalchemy_uri` to create a new SQLAlchemy engine. This works as 
expected if the URI does not contain a password - however if it does, this 
string contains the masked password (i.e. XXXXXXXX), and authentication is 
attempted using that instead. 
   
   This change should fix #4285 and #4287.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to